Move all git prompt logic to C #15

New Issue

benie · 2018-09-08T09:15:15Z

benie commented

2018-09-08 09:15:15 +00:00

Currently the git-prompt C program only parses the output of git status --porcelain leaving a large amount of logic up to zsh script to handle color
output. This was done to avoid writing raw escape sequences however git-prompt
could easily output zsh syntax for outputting color e.g. %{%B%F{2}%}✓%{%f%b%}
which could then be interpreted by zsh to perform the colorizing.

Additionally, running git-prompt could then become unconditional, if there is
no git repository then no output would be provided.

Currently the `git-prompt` C program only parses the output of `git status --porcelain` leaving a large amount of logic up to zsh script to handle color output. This was done to avoid writing raw escape sequences however `git-prompt` could easily output zsh syntax for outputting color e.g. `%{%B%F{2}%}✓%{%f%b%}` which could then be interpreted by zsh to perform the colorizing. Additionally, running `git-prompt` could then become unconditional, if there is no git repository then no output would be provided.

benie commented

2018-10-11 19:11:23 +00:00

Fixed in 5f2c5b58da.

Fixed in 5f2c5b58da52223803339676cec43c883a52a84f.

benie closed this issue

2018-10-11 19:11:24 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: config/zsh#15